feat: migrate Navigation and update FileAction from server #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
force-pushed
the
feat/new-menu-context
branch
from
09e0f26 to
4854b0c
Compare
skjnldsv
changed the title
skjnldsv
force-pushed
the
feat/new-menu-context
branch
2 times, most recently
from
e154887 to
ce9f36c
Compare
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
feat/new-menu-context
branch
from
ce9f36c to
d86dade
Compare
juliusknorr
reviewed
Aug 18, 2023
susnux
approved these changes
Aug 18, 2023
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
we should add tests at least in a follow up but overall this looks good :)
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.