Skip to content

Conversation

@skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Jul 6, 2023

We should be allowed to specify a property as undefined

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv requested a review from susnux July 6, 2023 09:36
@skjnldsv skjnldsv self-assigned this Jul 6, 2023
@skjnldsv skjnldsv added the 3. to review 3️⃣ Waiting for reviews label Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c07a9e5) 100.00% compared to head (48a6ba7) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #683   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          236       236           
  Branches        69        69           
=========================================
  Hits           236       236           
Impacted Files Coverage Δ
lib/files/nodeData.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skjnldsv skjnldsv merged commit 36f0f2f into master Jul 25, 2023
@skjnldsv skjnldsv deleted the fix/allow-undefined branch July 25, 2023 08:43
@skjnldsv skjnldsv mentioned this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review 3️⃣ Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants