Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add icons for filepicker and allow reactive button based on current path and selection #938

Merged
merged 3 commits into from
Aug 24, 2023
Merged

feat: Add icons for filepicker and allow reactive button based on current path and selection #938

merged 3 commits into from
Aug 24, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 24, 2023

  • Emit close event when a button is pressed with selected files as payload
  • Support button factories which can be used to create reactive buttons (e.g. labels like move to...)
  • Allow to pass SVGs as icons

Screenshot_20230824_044217
Screenshot_20230824_044221

@susnux susnux requested review from skjnldsv, Pytal and szaimen August 24, 2023 02:46
@susnux susnux mentioned this pull request Aug 23, 2023
Open
15 tasks
susnux added 3 commits August 24, 2023 07:55
@susnux @skjnldsv
feat(Dialogs): Allow to pass SVGs as icons
3905f57 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux @skjnldsv
feat(FilePicker): Support button factories which can be used to creat…
2fa0fc4 
…e reactive buttons (e.g. labels like `move to...`)

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux @skjnldsv
feat(FilePicker): Emit close event when a button is pressed with sele…
8b9b6d0 
…cted files as payload

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@skjnldsv skjnldsv force-pushed the feat/icons-and-target branch from f27e663 to 8b9b6d0 Compare August 24, 2023 05:55
@skjnldsv skjnldsv enabled auto-merge August 24, 2023 05:56
@skjnldsv skjnldsv merged commit ed9b0b0 into master Aug 24, 2023
@skjnldsv skjnldsv deleted the feat/icons-and-target branch August 24, 2023 05:57
@skjnldsv skjnldsv mentioned this pull request Aug 24, 2023
Merged
@susnux susnux mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@szaimen szaimen Awaiting requested review from szaimen

Assignees
No one assigned
Labels
3. to review backport-request enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susnux @skjnldsv