fix: Also add current folder to button factory #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
commented
Jun 8, 2024
| @@ -189,7 +190,7 @@ const viewHeadline = computed(() => currentView.value === 'favorites' ? t('Favor | |||
| /** | |||
| * All currently selected files | |||
| */ | |||
| const selectedFiles = ref<Node[]>([]) | |||
| const selectedFiles = shallowReactive<Node[]>([]) | |||
There was a problem hiding this comment.
This needs to be a shallow reactive, meaning the array is reactive, but not the inner elements.
This is required to fix Typescript, as Vue unrefs the inner nodes for ref which will strip off any private properties of the Node type. This causes Typescript issues as the types Ref<Node>.value != Node.
susnux
commented
Jun 8, 2024
| const navigatedPath = ref<string>() | ||
| const navigatedPath = ref('') | ||
| // Save the navigated path to the session storage on change | ||
| watch([navigatedPath], () => { |
There was a problem hiding this comment.
Instead of the writable computed below we can simply watch this and then react to it. Because doing login in writable computed properties seems to be bad.
susnux
force-pushed
the
fix/add-current-folder-button-factory
branch
from
50adb46
to
000938d
Compare
susnux
commented
Jun 8, 2024
| @@ -114,7 +114,15 @@ export const useDAVFiles = function( | |||
| /** | |||
| * All files in current view and path | |||
| */ | |||
| const files = ref<Node[]>([] as Node[]) as Ref<Node[]> | |||
| const files = shallowRef<Node[]>([] as Node[]) as Ref<Node[]> | |||
There was a problem hiding this comment.
Same reason as for the shallowReactive but here we can use shallowRef because it only needs to be reactive on change of the value, we do not change the array.
susnux
force-pushed
the
fix/add-current-folder-button-factory
branch
from
000938d
to
70b3e6b
Compare
…`allowPickDirectory` is true Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/add-current-folder-button-factory
branch
from
70b3e6b
to
110ddce
Compare
artonge
approved these changes
Jun 10, 2024
ShGKme
approved these changes
Jun 10, 2024
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When picking directories and no node is selected the current directory is picked, this is correctly submitted but it is currently not correctly included in the button factory.
Meaning you can for example not check if you can pick the current directory (readonly directory).
Required for nextcloud/server#45688