Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FilePicker): Allow using on public shares #1241

Merged
merged 4 commits into from
Feb 21, 2024
Merged

fix(FilePicker): Allow using on public shares #1241

merged 4 commits into from
Feb 21, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 20, 2024 •
edited
Loading

Only query settings from the files app when we are on the internal view.
Also adjusted the webdav endpoint used when we are on a public share.

@susnux susnux requested review from artonge, Pytal and ShGKme February 20, 2024 20:18
@susnux susnux changed the title Fix/public shares fix(FilePicker): Allow using on public shares Feb 20, 2024
@susnux susnux added bug Something isn't working 3. to review labels Feb 20, 2024
@susnux susnux modified the milestones: 5.1.0, 5.1.2 Feb 20, 2024
@susnux susnux marked this pull request as ready for review February 20, 2024 20:48
@susnux
Copy link
Contributor Author

susnux commented Feb 21, 2024

/backport! to stable4

@backportbot backportbot bot mentioned this pull request Feb 21, 2024
Closed
2 tasks
@susnux susnux mentioned this pull request Feb 21, 2024
Merged
@susnux susnux requested a review from skjnldsv February 21, 2024 13:50
@emoral435 emoral435 self-requested a review February 21, 2024 16:04
emoral435
emoral435 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! Haven't tested it, though!

lib/composables/dav.ts Outdated Show resolved Hide resolved
susnux and others added 4 commits February 21, 2024 22:11
@susnux @emoral435
fix(FilePicker): Adjust DAV composable to be able to work on public `…
83b7b7d 
…webdav` endpoint

Co-authored-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(FilePicker): Only load files views and files config on internal r…
d3c4e26 
…outes

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(FilePicker): Cleanup code a bit
adfd9ee 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Extract translations
4857e5c 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux enabled auto-merge February 21, 2024 21:11
@susnux susnux merged commit 691fc36 into main Feb 21, 2024
11 checks passed
@susnux susnux deleted the fix/public-shares branch February 21, 2024 21:13
@ShGKme
Copy link
Contributor

ShGKme commented Feb 23, 2024 •
edited
Loading

Is there a plan to have a release with this fix soon?

This allows using the component outside the server-rendered page, for example, in Talk Desktop.

@susnux
Copy link
Contributor Author

susnux commented Feb 23, 2024

This is already released in 5.1.2

@ShGKme
Copy link
Contributor

ShGKme commented Feb 23, 2024

This is already released in 5.1.2

Thanks! Sorry, I checked only by milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emoral435 emoral435 emoral435 approved these changes

@artonge artonge Awaiting requested review from artonge

@Pytal Pytal Awaiting requested review from Pytal

@ShGKme ShGKme Awaiting requested review from ShGKme

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
5.1.2
Development

Successfully merging this pull request may close these issues.

[Bug]: Move or copy file on link share does not work
3 participants
@susnux @ShGKme @emoral435