Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always use a generated id for User.id #9793

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

balazsorban44
Copy link
Member

Fixes #9699

☕️ Reasoning

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented Jan 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
auth-docs ⬜️ Ignored (Inspect) Jan 25, 2024 1:59pm
next-auth-docs ⬜️ Ignored (Inspect) Jan 25, 2024 1:59pm

@yordis
Copy link
Contributor

yordis commented Feb 7, 2024

@balazsorban44 do you mind sharing the Reasoning behind overwriting the id coming from the profile callback?

I wouldn't expect this behavior to happen. I would expect the user's identity to be managed by the Provider, or I would use the profile callback to overwrite it if I want to change it.

Otherwise, sure, fallback to the default one, but respecting what I decide to be the Identity is critical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default ID generation overridden by oauth (google) user profile
2 participants