-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(adapters): Drizzle adapter #8258
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested it locally, but in general lgtm.
Some general feedback though, do we really need separate method implementations for each underlying db type (MySQL, postgres, etc.)?
Also these inline docs for TS hinting are getting a bit long 😅
Co-authored-by: Anthony Shew <anthonyshew@gmail.com>
@balazsorban44 why all functions from SQLiteDrizzleAdapter are not async/await like the pg/mysql ? |
Finishing up @anthonyshew's PR #7165
Introducing a
drizzle-orm
adapter!With
drizzle
's increasing popularity, it's no surprise that there's a discussion for an adapter. This PR adds it.Notes
instanceof
checks to allow for multiple drizzle-orm instances to be used drizzle-team/drizzle-orm#283runBasicTests
utility to be able to provide some custom fixtures to workaround this. [mysql] Stop truncating timestamp milliseconds drizzle-team/drizzle-orm#668Closes #7165