Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert #6814 #7125

Merged
merged 1 commit into from
Apr 2, 2023
Merged

fix: revert #6814 #7125

merged 1 commit into from
Apr 2, 2023

Conversation

ThangHuuVu
Copy link
Member

NOTE:

  • It's a good idea to open an issue first to discuss potential changes.
  • Please make sure that you are NOT opening a PR to fix a potential security vulnerability. Instead, please follow the Security guidelines to disclose the issue to us confidentially.

☕️ Reasoning

Revert #6814 regarding #6949. For corporate proxy setup, we recommend using this one-liner workaround:

export default function auth(req: NextApiRequest, res: NextApiResponse) {
  req.headers['x-forwarded-host'] = process.env.NEXTAUTH_URL
  return NextAuth(req, res, authOptions)
}

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Please scout and link issues that might be solved by this PR.

Fixes: #6949

📌 Resources

@vercel
Copy link

vercel bot commented Apr 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Updated (UTC)
auth-docs ⬜️ Ignored (Inspect) Apr 1, 2023 4:37pm
auth-docs-nextra ⬜️ Ignored (Inspect) Apr 1, 2023 4:37pm
next-auth-docs ⬜️ Ignored (Inspect) Apr 1, 2023 4:37pm

@github-actions github-actions bot added adapters Changes related to the core code concerning database adapters core Refers to `@auth/core` frameworks legacy Refers to `next-auth` v4. Minimal maintenance. providers svelte labels Apr 1, 2023
@ThangHuuVu ThangHuuVu changed the base branch from main to v4 April 1, 2023 16:37
@ThangHuuVu ThangHuuVu removed providers adapters Changes related to the core code concerning database adapters core Refers to `@auth/core` frameworks svelte labels Apr 1, 2023
@ThangHuuVu ThangHuuVu marked this pull request as ready for review April 2, 2023 03:51
@balazsorban44 balazsorban44 merged commit d890177 into v4 Apr 2, 2023
@balazsorban44 balazsorban44 deleted the fix/revert-6814 branch April 2, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy Refers to `next-auth` v4. Minimal maintenance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NEXTAUTH_URL_INTERNAL=http://nextjs:3000 fails in docker using next-auth 4.20.1
2 participants