-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@auth/remix framework for using @auth in remix #6767
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Balázs Orbán <info@balazsorban.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Thank you! Small note, we are still very much interested, but our priority is on making the core more stable and finishing up the docs migration (https://next-auth.js.org and https://authjs.dev have a lot of shared content right now). Once that's done, we will have more time to look into new frameworks again! 💚 In the meantime, I was wondering about your opinion on this comment by @sergiodxa: #6246 (reply in thread), considering that there is https://remix.run/docs/en/v1/utils/sessions |
No problem, it seems silly to merge it when that remix bug means you have to use a patch and for some reason they still haven't merged in the fix. But yes I agree it would be easier to work with remix if it didn't return a response object and just the info you needed to create the response. Not even mainly to use the built in remix session storage methods, although that could be especially nice for things like cloudflare. But mainly after playing with it a lot and the best way to integrate it, is as I lay out in the README, is using a This ends up working fine for most things as if it succeeds you can easily show they are signed in. But for errors you can tell it encountered an error via the response code but would need to parse the html response to see if it's something you want to tell the user like if the email already exists in the database. Also it becomes a pain for strategies that succeed but don't log the user in like with email magic links. |
9784f29
to
37bb6eb
Compare
fa96b45
to
65aa467
Compare
@acoreyj just a ping reminder. Is it possible to finish the work you have started here? Do you have an y plans for that? |
@acoreyj now that Remix moved to Vite, is this more feasible to become a reality? |
Yeah it'd be great if you could double check this against the latest versions of Remix! The way I see it, I can't imagine the framework will disappear in any sense. Shopify bought them as replacement for their homegrown framework and as a competitor to Vercel/next, netlify/gatsby, etc. |
@acoreyj is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
You shouldn't touch the package.json version manually. Just set it to |
@ndom91 thanks but i decided to use Next, but if I ever try Remix again in the future I'll try it out |
Maybe the name should change to '@auth/react-router' because Remix will be merged into the upcoming React Router 7 |
☕️ Reasoning
Integrate auth.js into a remix project
🧢 Checklist
Note this is working in my testing but setup a good example project and merge I need at least the first and preferably both of the following remix issues fixed/merged
remix-run/remix#4148
remix-run/remix#3330
But I'm reopening this MR because some people have expressed interest in using the code
📌 Resources