Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drop crypto dependency, convert to ESM #6603

Merged
merged 6 commits into from
Feb 5, 2023
Merged

feat: drop crypto dependency, convert to ESM #6603

merged 6 commits into from
Feb 5, 2023

Conversation

ThangHuuVu
Copy link
Member

☕️ Reasoning

  • Export dynamodb adapter as ESM only package
  • Bump to 2.0.0
  • use uuid for id generation

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Please scout and link issues that might be solved by this PR.

Fixes: #6582

📌 Resources

@vercel
Copy link

vercel bot commented Feb 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
auth-docs ❌ Failed (Inspect) Feb 4, 2023 at 2:54PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
next-auth-docs ⬜️ Ignored (Inspect) Feb 4, 2023 at 2:54PM (UTC)

@github-actions github-actions bot added adapters Changes related to the core code concerning database adapters dynamodb @auth/dynamodb-adapter labels Feb 2, 2023
@ThangHuuVu
Update package.json
e39524f 
Update package.json
@balazsorban44 balazsorban44 changed the title feat: export adapter-dynamodb as ESM only feat: drop crypto dependency, convert to ESM Feb 3, 2023
balazsorban44
balazsorban44 approved these changes Feb 4, 2023
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for Adam's response 👍

balazsorban44
balazsorban44 reviewed Feb 4, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@ThangHuuVu
Copy link
Member Author

@balazsorban44 Adam said it worked! Let's merge this 🙌

@balazsorban44 balazsorban44 merged commit 28583b8 into main Feb 5, 2023
@balazsorban44 balazsorban44 deleted the feat/dynamodb-esm branch February 5, 2023 13:44
@koorukuroo
Copy link

Dear @ThangHuuVu , use uuid for id generation cause the - creation in userId.

Old : 437bf79501ea5c66955a25f5053f3fa9
New : dd1add78-68ef-47c9-8036-071ad643d6b0

Are there any dependencies on this? 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@ndom91 ndom91 Awaiting requested review from ndom91 ndom91 is a code owner

@ubbe-xyz ubbe-xyz Awaiting requested review from ubbe-xyz ubbe-xyz is a code owner

Assignees
No one assigned
Labels
adapters Changes related to the core code concerning database adapters dynamodb @auth/dynamodb-adapter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamo adapter can't deploy to edge
3 participants
@ThangHuuVu @koorukuroo @balazsorban44