fix(providers): conform Twitch provider to spec with escape hatch #6365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
balazsorban44
changed the title
balazsorban44
had a problem deploying
to
Preview
GitHub Actions
Failure
balazsorban44
had a problem deploying
to
Preview
GitHub Actions
Failure
balazsorban44
had a problem deploying
to
Preview
GitHub Actions
Failure
ThangHuuVu
reviewed
Jan 12, 2023
ThangHuuVu
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6363
This PR introduces a new
conform()callback for thetokenOAuth config option. It's marked as internal for now, and not expected to be used in user-land. This is an escape hatch to work around non-conformities in our built-in providers in a way that does not require a fullrequestoverride, but also does not add special handling to providers into the core.This is a last resort, and ideally, such issues should be fixed on the Provider side. If you see this method and have the power, we encourage you to put pressure on the given provider so they fix the issue on their side.
Once a non-conformity is fixed, the
conform()method will be pass-through and will show a warning. In this case, you can file an issue on this repo so we can remove the workaround.