refactor: rewrite core to TypeScript #2552

balazsorban44 · 2021-08-17T22:58:06Z

re-enable tests
fix bundling (split between client and server, follow Next.js)
fix CSS import
~~fix dev app imports (check out Experimental feature for allowing importing Typescript files outside of the root directory vercel/next.js#22867)~~ will do in subsequent PR

vercel · 2021-08-17T22:58:08Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/D5A29RF9vCtjCHNSb3utDMeDbkW5
✅ Preview: https://next-auth-git-feat-typescript-nextauthjs.vercel.app

[Deployment for 76ab39f failed]

github-actions · 2021-08-17T23:47:48Z

🎉 Experimental release published on npm!

npm i next-auth@0.0.0-pr.2552.f73a37a5

yarn add next-auth@0.0.0-pr.2552.f73a37a5

ubbe-xyz

Half-way reviewing this ✨ , it's really impressive you manage to pull this off in almost one go 🤯 💯 🥇

I leave a few questions/suggestions on the project structure 💭 , I plan to finish the review tomorrow 👍🏽

src/index.ts

src/jwt.ts

Conflicts: src/client/react.js src/react/index.tsx types/tests/react.test.ts

ndom91

I tried to run this locally, but no matter what I did, I could not get it to recognize next-auth/react.

~~Kept getting module not found: can't resolve 'next-auth/react' errors 😢~~

Balazs and I figured it out!

ubbe-xyz

Super 💯 ⚡️ ✨ , minor last questions/suggestions before merge 💚

ubbe-xyz · 2021-08-30T10:49:21Z

src/lib/merge.ts

- */
-export function merge(target, ...sources) {
+/** Deep merge two objects */
+export function merge(target: any, ...sources: any[]) {


Maybe we can refine the types of this a bit more 💅🏽

Suggested change

export function merge(target: any, ...sources: any[]) {

type UnknownObj = Record<string, any>

export function merge(target: UnknownObj, ...sources: UnknownObj[]) {

ubbe-xyz · 2021-08-31T12:06:43Z

src/providers/auth0.ts

@@ -17,5 +18,5 @@ export default function Auth0(options) {
      }
    },
    options,
-  }
+  } as any


Is it possible to refine here so we don't use any?

ubbe-xyz · 2021-08-31T12:14:06Z

src/server/index.ts

  if (userOptions.logger) {
    setLogger(userOptions.logger)
  }
  // If debug enabled, set ENV VAR so that logger logs debug messages
  if (userOptions.debug) {
-    process.env._NEXTAUTH_DEBUG = true
+    ;(process.env._NEXTAUTH_DEBUG as any) = true


I think we can declare the global env variables we rely on like this:

// src/global.d.ts interface NextAuthEnv { _NEXTAUTH_DEBUG: 'true' | 'false' | undefined; // ... } interface GlobalProcess { env: NextAuthEnv; } declare const process: GlobalProcess;

ubbe-xyz · 2021-08-31T12:15:24Z

src/server/index.ts

+function NextAuth(options: NextAuthOptions): any
+function NextAuth(
+  req: NextApiRequest,
+  res: NextApiResponse,
+  options: NextAuthOptions
+): any


Any chance this will work?

function NextAuthHandler(options: NextAuthOptions): ReturnType<NextAuthHandler>

ubbe-xyz · 2021-08-31T12:20:08Z

tsconfig.json

    "lib": ["dom", "dom.iterable", "esnext"],
    "allowJs": true,
-    "skipLibCheck": true,
    "strict": false,


I wonder if we can switch to strict: true and rely on // @ts-expect-error for the errors we don't want to fix just yet? 💭

balazsorban44 · 2021-08-31T13:17:52Z

All concerns will be addressed in a separate PR, thank you @lluia!

ubbe-xyz

Let's get this in 💯 🎊 ❤️

* chore(deps): upgrade TS packages * build(ts): use tsc to compile * refactor(ts): move some files to TS * chore: implement SkyPack check suggestions * chore(ci): temprarily disable tests * chore: add PR comment action * chore: add determine version github action * chore: prefix with env. * chore: add runs to action * chore: change runs.using to node12 * chore: fix typo * chore: install @actions/core as dev dependency * chore: move env var, remove old script * chore: change version comment message * refactor(ts): convert server/index.js to TS * chore: fix `types` path * chore: fix paths * refactor(ts): convert `next-auth/react` * refactor(ts): convert `next-auth/jwt` to TS * chore: fix import * refactor: move `types` into `src` * refactor(ts): fix types imports * chore: add cleanup script * chore: exclude all `tests` folder from compilation * refactor: rename types/index.d.ts to types/index.ts * refactor(ts): move `next-auth/jwt` * refactor(ts): move `next-auth/providers` * chore(ts): fix `next-auth` types * refactor(ts): change internal import paths * test(ts): remove type tests * chore: remove test:types script * refactor(ts): move more code to TypeScript * refactor: fix some imports * refactor(ts): move error module into server * fix(ts): add type to .js providers * chore: rename adapters.ts to adapters.d.ts * fix: update exports field * chore: add files that should end up on npm * chore: add stricter lib checking * refactor(ts): remove unnecessary files, fix imports * chore: autocomplete env variables * fix: add css folder to npm files * fix: fix CSS import/generation * feat: log provider when authorization url error happens * refactor(ts): turn pages into .tsx * chore: compile differently for client/server * refactor(ts): move server file to TS * chore: add back node target * chore: add back comment removal * chore: re-enable tests * chore: ignore test files when building * chore(ts): refactor files to TS * chore(ts): fix imports * chore(ts): more ts * fix(ts): correctly type _NEXTAUTH_DEBUG env var * chore: don't generate internals module iwth babel * fix(ts): better `clientId`, `clientSecret` constraints * refactor(ts): move facebook provider to TS * refactor(ts): apply suggested changes * chore(ts): strip internal types from compilation * refactor(ts): move server types to server folder * refactor(ts): rename internals to types

balazsorban44 added 3 commits August 18, 2021 00:54

chore(deps): upgrade TS packages

8c915d1

build(ts): use tsc to compile

094f870

refactor(ts): move some files to TS

d9af235

github-actions bot added core Refers to `@auth/core` providers TypeScript Issues relating to TypeScript labels Aug 17, 2021

balazsorban44 added 2 commits August 18, 2021 01:18

chore: implement SkyPack check suggestions

fcfa07a

chore(ci): temprarily disable tests

8bc510d

vercel bot temporarily deployed to Preview August 17, 2021 23:18 Inactive

balazsorban44 temporarily deployed to Preview August 17, 2021 23:18 Inactive

chore: add PR comment action

201613e

vercel bot temporarily deployed to Preview August 17, 2021 23:46 Inactive

balazsorban44 temporarily deployed to Preview August 17, 2021 23:46 Inactive

chore: add determine version github action

2e2e3ae

vercel bot temporarily deployed to Preview August 18, 2021 00:35 Inactive

chore: prefix with env.

d9e4981

vercel bot temporarily deployed to Preview August 18, 2021 00:37 Inactive

balazsorban44 had a problem deploying to Preview August 18, 2021 00:37 Failure

chore: add runs to action

c278039

vercel bot temporarily deployed to Preview August 18, 2021 00:38 Inactive

balazsorban44 had a problem deploying to Preview August 18, 2021 00:38 Failure

chore: change runs.using to node12

e303f17

vercel bot temporarily deployed to Preview August 18, 2021 00:40 Inactive

balazsorban44 had a problem deploying to Preview August 18, 2021 00:40 Failure

chore: fix typo

97bfc48

vercel bot temporarily deployed to Preview August 18, 2021 00:41 Inactive

balazsorban44 had a problem deploying to Preview August 18, 2021 00:41 Failure

vercel bot temporarily deployed to Preview August 18, 2021 00:43 Inactive

vercel bot had a problem deploying to Preview August 27, 2021 11:29 Failure

balazsorban44 had a problem deploying to Preview August 27, 2021 11:30 Failure

balazsorban44 added 2 commits August 27, 2021 14:04

fix(ts): better clientId, clientSecret constraints

ffa512e

refactor(ts): move facebook provider to TS

011843d

vercel bot had a problem deploying to Preview August 27, 2021 12:04 Failure

balazsorban44 had a problem deploying to Preview August 27, 2021 12:05 Failure

ubbe-xyz reviewed Aug 27, 2021

View reviewed changes

src/index.ts Show resolved Hide resolved

src/jwt.ts Outdated Show resolved Hide resolved

src/jwt.ts Outdated Show resolved Hide resolved

refactor(ts): apply suggested changes

1b5b5f8

vercel bot had a problem deploying to Preview August 28, 2021 23:29 Failure

chore(ts): strip internal types from compilation

10badfd

vercel bot had a problem deploying to Preview August 28, 2021 23:58 Failure

refactor(ts): move server types to server folder

d203b0a

vercel bot had a problem deploying to Preview August 29, 2021 00:04 Failure

refactor(ts): rename internals to types

1f95be1

vercel bot had a problem deploying to Preview August 29, 2021 00:12 Failure

Merge branch 'next'

76ab39f

Conflicts: src/client/react.js src/react/index.tsx types/tests/react.test.ts

vercel bot had a problem deploying to Preview August 29, 2021 00:24 Failure

balazsorban44 temporarily deployed to Preview August 29, 2021 00:25 Inactive

balazsorban44 mentioned this pull request Aug 29, 2021

Preact will cause the mongodb package to not be found? #2622

Closed

ndom91 reviewed Aug 29, 2021

View reviewed changes

ubbe-xyz reviewed Aug 31, 2021

View reviewed changes

ubbe-xyz approved these changes Aug 31, 2021

View reviewed changes

balazsorban44 merged commit e099223 into next Aug 31, 2021

balazsorban44 deleted the feat/typescript branch August 31, 2021 13:18

balazsorban44 mentioned this pull request Aug 31, 2021

refactor(dev): use Next.js externalDir to fix dev app #2631

Merged

This was referenced Sep 9, 2021

Comply with TypeScript strict mode #2709

Closed

User object is empty #2757

Closed

balazsorban44 mentioned this pull request Sep 29, 2021

refactor: decouple Next.js from core #2857

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: rewrite core to TypeScript #2552

refactor: rewrite core to TypeScript #2552

balazsorban44 commented Aug 17, 2021 •

edited

Loading

vercel bot commented Aug 17, 2021 •

edited

Loading

github-actions bot commented Aug 17, 2021 •

edited

Loading

ubbe-xyz left a comment

ndom91 left a comment •

edited

Loading

ubbe-xyz left a comment

ubbe-xyz Aug 30, 2021 •

edited by balazsorban44

Loading

ubbe-xyz Aug 31, 2021

ubbe-xyz Aug 31, 2021

ubbe-xyz Aug 31, 2021

ubbe-xyz Aug 31, 2021

balazsorban44 commented Aug 31, 2021

ubbe-xyz left a comment

-export function merge(target: any, ...sources: any[]) {
+type UnknownObj = Record<string, any>
+export function merge(target: UnknownObj, ...sources: UnknownObj[]) {

refactor: rewrite core to TypeScript #2552

refactor: rewrite core to TypeScript #2552

Conversation

balazsorban44 commented Aug 17, 2021 • edited Loading

vercel bot commented Aug 17, 2021 • edited Loading

github-actions bot commented Aug 17, 2021 • edited Loading

ubbe-xyz left a comment

Choose a reason for hiding this comment

ndom91 left a comment • edited Loading

Choose a reason for hiding this comment

ubbe-xyz left a comment

Choose a reason for hiding this comment

ubbe-xyz Aug 30, 2021 • edited by balazsorban44 Loading

Choose a reason for hiding this comment

ubbe-xyz Aug 31, 2021

Choose a reason for hiding this comment

ubbe-xyz Aug 31, 2021

Choose a reason for hiding this comment

ubbe-xyz Aug 31, 2021

Choose a reason for hiding this comment

ubbe-xyz Aug 31, 2021

Choose a reason for hiding this comment

balazsorban44 commented Aug 31, 2021

ubbe-xyz left a comment

Choose a reason for hiding this comment

balazsorban44 commented Aug 17, 2021 •

edited

Loading

vercel bot commented Aug 17, 2021 •

edited

Loading

github-actions bot commented Aug 17, 2021 •

edited

Loading

ndom91 left a comment •

edited

Loading

ubbe-xyz Aug 30, 2021 •

edited by balazsorban44

Loading