Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): enhance api reference with styles for providers #11961

Merged

Conversation

halvaradop
Copy link
Contributor

@halvaradop halvaradop commented Oct 3, 2024

☕️ Reasoning

This pull request introduces global styles for the providers API reference to ensure consistent background and text colors for the main description, while preventing users from inputting arbitrary colors that could disrupt the website's uniformity; the following images illustrate the implemented changes.

Screenshots

Before
image
image

After
image
image

there are some suppliers that establish these properties

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 7:09pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Oct 28, 2024 7:09pm

Copy link

vercel bot commented Oct 3, 2024

@halvaradop is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 86 lines in your changes missing coverage. Please review.

Project coverage is 60.42%. Comparing base (ad15137) to head (35308de).

Files with missing lines Patch % Lines
packages/core/src/providers/42-school.ts 0.00% 1 Missing ⚠️
packages/core/src/providers/apple.ts 0.00% 1 Missing ⚠️
packages/core/src/providers/asgardeo.ts 0.00% 1 Missing ⚠️
packages/core/src/providers/auth0.ts 0.00% 1 Missing ⚠️
packages/core/src/providers/authentik.ts 0.00% 1 Missing ⚠️
packages/core/src/providers/azure-ad-b2c.ts 0.00% 1 Missing ⚠️
packages/core/src/providers/azure-ad.ts 0.00% 1 Missing ⚠️
packages/core/src/providers/bankid-no.ts 0.00% 1 Missing ⚠️
packages/core/src/providers/battlenet.ts 0.00% 1 Missing ⚠️
packages/core/src/providers/beyondidentity.ts 0.00% 1 Missing ⚠️
... and 76 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #11961       +/-   ##
===========================================
+ Coverage   39.05%   60.42%   +21.36%     
===========================================
  Files         191      136       -55     
  Lines       29994     6385    -23609     
  Branches     1294      532      -762     
===========================================
- Hits        11715     3858     -7857     
+ Misses      18279     2527    -15752     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement, thanks!

@ndom91 ndom91 force-pushed the chore/improve-styles-api-references branch from 35308de to 217e054 Compare October 28, 2024 19:04
@ndom91 ndom91 merged commit a88c7a3 into nextauthjs:main Oct 28, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants