Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add link to azure tables adapter documentation #11899

Merged

Conversation

halvaradop
Copy link
Contributor

☕️ Reasoning

This pull request adds the missing link to the Azure Tables Adapter documentation in the README file, making it easier for users to access information about the package.

Additionally, I would suggest adding more comprehensive information to the README files of the core and next-auth packages. As they are the main packages of the library, enhancing these documents with more detailed descriptions could provide better guidance and clarity for users and contributors. What do you think?

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 2:53am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 2:53am

Copy link

vercel bot commented Sep 24, 2024

@halvaradop is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added adapters Changes related to the core code concerning database adapters azure-tables labels Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.78%. Comparing base (538dd77) to head (7036954).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11899   +/-   ##
=======================================
  Coverage   38.78%   38.78%           
=======================================
  Files         189      189           
  Lines       29818    29818           
  Branches     1278     1278           
=======================================
  Hits        11565    11565           
  Misses      18253    18253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Regarding adding more info to the README, it would make us have to split documentation efforts. Initially, we had more information in the package READMEs.

But maybe it's worth revisiting...?

@halvaradop I have noticed your contributions, and we really appreciae them! If you would like to have closer collaboration, feel free to reach out to my on https://x.com/balazsorban44 or discord.authjs.dev! 💚

@balazsorban44 balazsorban44 merged commit e981d94 into nextauthjs:main Sep 25, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapters Changes related to the core code concerning database adapters azure-tables
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants