Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(providers): add Vipps provider #11832

Merged
merged 2 commits into from
Sep 15, 2024
Merged

feat(providers): add Vipps provider #11832

merged 2 commits into from
Sep 15, 2024

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Sep 15, 2024

Closes #6713

Also slight tweak on the default signin page so we can use non-rectangle logos nicely

image

image

☕️ Reasoning

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented Sep 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2024 10:44am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Sep 15, 2024 10:44am
proxy ⬜️ Ignored (Inspect) Sep 15, 2024 10:44am

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 1.13636% with 87 lines in your changes missing coverage. Please review.

Project coverage is 39.24%. Comparing base (96416ab) to head (411df54).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
packages/core/src/providers/vipps.ts 0.00% 86 Missing ⚠️
packages/core/src/providers/azure-ad-b2c.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11832      +/-   ##
==========================================
- Coverage   39.35%   39.24%   -0.12%     
==========================================
  Files         185      186       +1     
  Lines       29346    29428      +82     
  Branches     1264     1271       +7     
==========================================
- Hits        11549    11548       -1     
- Misses      17797    17880      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, makes sense 👍

@balazsorban44 balazsorban44 merged commit 120f550 into main Sep 15, 2024
12 of 15 checks passed
@balazsorban44 balazsorban44 deleted the feat/vipps branch September 15, 2024 14:04
@sommeeeer
Copy link
Contributor

sommeeeer commented Sep 19, 2024

#11869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants