Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add solidstart example app #11719

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

halvaradop
Copy link
Contributor

☕️ Reasoning

This pull request introduces an object containing information about SolidStart to be displayed on the root page of the documentation. It expands the documentation of the examples supported by Auth.js.

Screenshots:
image
image

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 9:52pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 9:52pm

Copy link

vercel bot commented Aug 29, 2024

@halvaradop is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@ndom91
Copy link
Member

ndom91 commented Aug 29, 2024

I like the initiative! However that example app doesn't exist yet, right.

@halvaradop
Copy link
Contributor Author

I'm not sure if the example app doesn't exist, but I saw that the repository contains this link. However, if you're referring to the link being broken, you're right. This link behaves the same as the Qwik example app link, so please check them.

@ndom91
Copy link
Member

ndom91 commented Sep 2, 2024

Okay so the Qwik one is fixed. The Solid-Start one is mostly fixed, but the example app won't be able to be deployed successfully until there's a new publish of the @auth/solid-start package due to some critical updates I just merged htere as well. Shouldn't take too long 🤞

@halvaradop
Copy link
Contributor Author

Thank you for considering my suggestions! I’ll be looking forward to the new auth/solid-start publication.

@balazsorban44
Copy link
Member

balazsorban44 commented Sep 4, 2024

This is not shown for a reason. We are not yet confident in our current implementation. The link you added even 404's. https://solid-start-auth-example.vercel.app/

Sorry, missed the discussion with @ndom91

Let's await merging it until the example is up and running.

@ndom91
Copy link
Member

ndom91 commented Sep 19, 2024

Why did you close? Still working on this haha

@halvaradop halvaradop restored the docs/add-solid-example-app branch September 19, 2024 14:44
@halvaradop halvaradop reopened this Sep 19, 2024
@halvaradop
Copy link
Contributor Author

Nooo 😔, I think I accidentally deleted the branch haha. I’ve reopened the PR. Thank you for letting me know

@ndom91
Copy link
Member

ndom91 commented Sep 22, 2024

The current state of this is as follows:

  • We need the solid-start-example-app Vercel project to deploy successfully so we can merge this because it points at that demo project.
  • We recently released a new version of the @auth/solid-start client which does build correctly
  • Howeverrr, the demo project is still having issues deploying on Vercel.

image

In the project's Vercel settings the node version is set to 20 and I updated the engines key in the package.json as well from "node": ">=16" to "node": "^18.17.0 || ^20.3.0 || >=21.0.0", but it still throws this error. Do you have any idea why else this might be throwing this error at build?

@halvaradop
Copy link
Contributor Author

I'm not sure, but I plan to deploy the demo. I’ll use the repo as a template for the deployment. If I have good results, I’ll get back to you with an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants