-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(adapter): add @auth/postgresjs-adapter #11200
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Someone is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Theres already an open PR adding an adapter using Ideally you two could sync and work on just 1 PR together 🙏 EDIT: Looks like that other user, @CodyBontecou, closed his PR in favor of this one |
hello! sounds good. are there any pending changes i need to make? |
Is that Give us some time to look over things. We're a bit swamped getting in the qwik, nuxt and other client libs atm |
Thanks for catching that... sorted!
no worries 😎 |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@types/set-cookie-parser@2.4.7, npm/@types/uuid@8.3.4, npm/@typescript-eslint/parser@v6.19.1, npm/dotenv@10.0.0, npm/nodemailer@6.9.14 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11200 +/- ##
=======================================
Coverage ? 97.59%
=======================================
Files ? 6
Lines ? 1289
Branches ? 142
=======================================
Hits ? 1258
Misses ? 31
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
||
runBasicTests({ | ||
adapter: PostgresJSAdapter(sql), | ||
db: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you've added the Authenticator
(PassKeys) methods, but didn't add the tests.
Can you add the testWebAuthnMethods: true
option here and the db: authenticator() ..
method? Check out the Prisma index.test.ts as an example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you've added the
Authenticator
(PassKeys) methods, but didn't add the tests.Can you add the
testWebAuthnMethods: true
option here and thedb: authenticator() ..
method? Check out the Prisma index.test.ts as an example
Alright.. ive added it!
☕️ Reasoning
Adding a new adapter using Postgres.js.
🧢 Checklist
🎫 Affected issues
📌 Resources