Fix .plot() method for 1D data groups with no nxcoordinates#250
Merged
rayosborn merged 1 commit intonexpy:mainfrom Feb 2, 2026
Merged
Fix .plot() method for 1D data groups with no nxcoordinates#250rayosborn merged 1 commit intonexpy:mainfrom
rayosborn merged 1 commit intonexpy:mainfrom
Conversation
Contributor
|
Thank you for the PR, which looks sound. It's a while since I made this change so I'm not sure why this problem has not appeared before but I confirmed that your fix works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent addition of
nxcoordinatelogic to theplot.pymodule has broken some downstream behavior, in my case for the.plot()method of 1D data groups. The following is a minimal example to recreate the issue:This raises the following:
The
plot.pymodule contains the following if/else logic:My assumption is that this if/if/else chain is actually meant to be an if/elif/else chain, which appears to resolve the issue and results in the expected behavior.
Let me know your thoughts.