Update README.md - practices-ng-commands - #23
Open
johnnyelwailer wants to merge 1 commit into
Open
Conversation
lulukas
approved these changes
Dec 18, 2025
johnnyelwailer
commented
Jul 5, 2026
johnnyelwailer
left a comment
Collaborator
Author
There was a problem hiding this comment.
Automated review: checked existing threads; added one unaccounted inline suggestion for the command README disabled-state example.
| <input formControlName="email" placeholder="Email" /> | ||
|
|
||
| <button [puiClickCommand]="saveCommand" [disabled]="saveCommand.disabledSignal()">Save</button> | ||
| <button [puiClickCommand]="saveCommand">Save</button> |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| <button [puiClickCommand]="saveCommand">Save</button> | |
| <button [puiClickCommand]="saveCommand" [disabled]="saveCommand.disabledSignal()">Save</button> |
🟡 Example no longer disables the save button
PuiClickCommandDirective only triggers commandSignal()?.trigger(...); it does not bind the host button's disabled attribute, so the form-save example still needs this binding to reflect saveCommand.disabledSignal().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change updates the
practices-ng-commandsREADME to simplify the documented usage example for thepuiClickCommanddirective. The example button previously bound the[disabled]attribute manually tosaveCommand.disabledSignal(), which is redundant because the directive already handles the disabled state internally. Removing the explicit binding keeps the documentation accurate and demonstrates the intended, more concise usage.How This Was Tested
No automated testing was performed as this is a documentation-only change to a single Markdown file. The updated example was reviewed for correctness against the directive's intended behavior.
Integration Instructions
N/A