fix: Use relative URLs to support ComfyUI hosted under a subpath#78
Open
ncaq wants to merge 1 commit into
Open
fix: Use relative URLs to support ComfyUI hosted under a subpath#78ncaq wants to merge 1 commit into
ncaq wants to merge 1 commit into
Conversation
When ComfyUI is served under a subpath by a reverse proxy, for example https://example.com/comfy-ui/, the absolute imports from /scripts/ fail with 404, and the whole extension silently fails to load. The absolute fetch() calls to /autocomplete-plus/* likewise miss the proxy prefix. Rewrite the imports relative to the module location, where extensions/<node-dir>/js/ is three levels below the ComfyUI root, and the fetch() URLs relative to the document base URL, so both resolve correctly whether ComfyUI is hosted at the root or under a subpath.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ComfyUI is served under a subpath by a reverse proxy,
for example https://example.com/comfy-ui/,
the absolute imports from /scripts/ fail with 404,
and the whole extension silently fails to load.
The absolute fetch() calls to /autocomplete-plus/* likewise miss the proxy prefix.
This PR rewrites the imports relative to the module location
(extensions//js/ is three levels below the ComfyUI root),
and the fetch() URLs relative to the document base URL,
so both resolve correctly whether ComfyUI is hosted at the root or under a subpath.
Tested by serving ComfyUI both at the root and behind a reverse proxy
(Tailscale Serve) under /comfy-ui/:
the extension loads and the tag CSV endpoints respond in both setups.