Skip to content

Conversation

@TinhHuynh
Copy link

@TinhHuynh TinhHuynh commented Jul 2, 2024

Hi, the PodPlayerController uses UniqueKey().toString() to generate a tag for the internal PodGetXController. However, in Flutter 3.22, there is an issue that UniqueKey always returns "Instance of UniqueKey" in release mode. No matter how many PodPlayerController are created, they still share the same PodGetXController instance.

To address this issue, I've replaced the usage of UniqueKey with Uuid for tag generation in the PodPlayerController class. Uuid is a safer and more standard approach for generating unique identifiers, and it ensures that each PodPlayerController instance will have a unique tag.

This change affects the _init method in the PodPlayerController class, where the getTag variable is assigned. I've tested the changes and confirmed that each PodPlayerController instance now receives a unique PodGetXVideoController instance as expected.

@TinhHuynh TinhHuynh mentioned this pull request Jul 3, 2024
@JannieT
Copy link

JannieT commented Nov 20, 2024

This might not be necessary anymore. It looks like the underlying issue has been fixed upstream and is now in stable since Flutter 3.24.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants