This repository was archived by the owner on Mar 29, 2024. It is now read-only.
add more flow control to to_spectrum #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richiverse
changed the title
lukeorland
suggested changes
Mar 8, 2019
| else '' | ||
| ) | ||
| return cleandoc(f""" | ||
| s3://{bucket}/{stream}/ext={file_format}/{partitioned_by}{stream} |
There was a problem hiding this comment.
Is there an extra {stream} after {partitioned_by} in this fstring?
Author
There was a problem hiding this comment.
yes this is for the filename itself
Author
There was a problem hiding this comment.
It shows up in both the s3 prefix and the filename itself
There was a problem hiding this comment.
ok, if this isn't a typo, I'll approve the PR.
lukeorland
approved these changes
Mar 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and deprecate to_parquet inside to_spectrum
This change is