Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/930-extend-toNewsKitIcon-types-2 #932

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

KayKostadinov
Copy link
Contributor

closes #930

What

  1. Background - why this is needed
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@KayKostadinov KayKostadinov requested a review from a team as a code owner June 21, 2024 14:20
@github-actions github-actions bot added the feature This change contains a new feature label Jun 21, 2024
@KayKostadinov
Copy link
Contributor Author

Theming e2e test fails when trying to release to prod due to a duplicate ID.

the failing pipeline:
https://app.circleci.com/pipelines/github/newscorp-ghfb/NewsKit/7493/workflows/daff3af7-9ed3-4ac0-89d3-bdefec61725a/jobs/168243
not reproducible locally

Disabling the test to unblock the pipeline

@KayKostadinov KayKostadinov merged commit 282b399 into main Jun 24, 2024
33 of 37 checks passed
@KayKostadinov KayKostadinov deleted the feat/930-extend-toNewsKitIcon-types-2 branch June 24, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This change contains a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend toNewsKitIcon parameter types
5 participants