-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add new sample mp3s for e2e tests and storybook #927
Conversation
You can preview these changes on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering what the reason is for removing these files on S3
@pdimova not 100% sure. The bucket exists but is empty. It's in the NGN dev account rather than NewsKit's, I think its the original bucket before the site origin was moved. |
I thought I'd moved the ncu-newskit-docs bucket from NGN to product platforms account a year ago. Not sure. I thought NGN was just being used to save the Terraform state. |
What
Previous mp3 test files used in Storybook and E2E tests has been removed, meaning E2E tests fail. This PR updates references to a new file, which will be self-hosted under the newskit.co.uk website. This PR will require forced merging with broken E2E and deploying through to prod. Subsequent builds should then work as normal.
I have done:
I have tested manually: