Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(WWP-3314): add usnat config to consent #924

Merged
merged 20 commits into from
Mar 1, 2024
Merged

feat(WWP-3314): add usnat config to consent #924

merged 20 commits into from
Mar 1, 2024

Conversation

kboeff
Copy link
Contributor

@kboeff kboeff commented Oct 23, 2023

https://nidigitalsolutions.jira.com/browse/WWP-3314

What

Background - why this is needed - Multi-State Privacy Agreement/String (MSPA) is a signal that notifies downstream partners that participating publishers have provided end-users with specific notice and choice over data processing activities on their properties. The Multi State Privacy Agreement is now available to implement on our properties alongside the U.S. Privacy String (USPS) with the intention that the MSPS will eventually supplant USPS.

What did you do - Updated Consent component to include the GPP stub file. Updated SP config to accept usnat object. This way both the new GPP string and legacy CCPA string are generated. For backwards compatibility the ccpa object is still available in Consent config.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:
The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
The screen reader reads and flows through the elements as expected.
There are no new errors in the browser console coming from this PR.
When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
The Playground feature is working as expected
Before:

After:
Using current branch build locally inside wd-web-platform project triggers gpp API correctly. Consent is called with the prop usnat: { includeUspApi: true }.
Screenshot 2023-10-31 at 11 56 53
The cookie value for ccpaUUID is still present.
Screenshot 2024-01-16 at 16 45 00

Who should review this PR:

How to test:
Consent component used with the usnat: { includeUspApi: true } should trigger GPP API as shown above. This is the test function:
__gpp('ping', (pingReturn, success) => {console.log('Ping request was successful: ' + success, pingReturn);});

@kboeff kboeff requested a review from a team as a code owner October 23, 2023 09:50
@github-actions github-actions bot added the feature This change contains a new feature label Oct 23, 2023
@pp-serviceaccount
Copy link
Collaborator

site/pages/components/consent.mdx Outdated Show resolved Hide resolved
site/pages/components/consent.mdx Outdated Show resolved Hide resolved
site/pages/components/consent.mdx Outdated Show resolved Hide resolved
src/consent/types.ts Outdated Show resolved Hide resolved
Copy link
Member

@lhaggar lhaggar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the docs page and a minor change is needed, but otherwise think it's looking good!

site/pages/components/consent.mdx Outdated Show resolved Hide resolved
lhaggar
lhaggar previously approved these changes Nov 2, 2023
@kboeff kboeff changed the title feat(WWP-3314): add gpp stub file to consent feat(WWP-3314): add usnat config to consent Jan 17, 2024
src/consent/types.ts Show resolved Hide resolved
src/consent/types.ts Outdated Show resolved Hide resolved
lhaggar
lhaggar previously approved these changes Jan 23, 2024
antoanetad78
antoanetad78 previously approved these changes Jan 23, 2024
ayush04
ayush04 previously approved these changes Jan 23, 2024
@kboeff kboeff dismissed stale reviews from ayush04, antoanetad78, and lhaggar via beb06c2 January 24, 2024 13:04
lhaggar
lhaggar previously approved these changes Jan 24, 2024
@ayush04 ayush04 merged commit 263618e into main Mar 1, 2024
34 of 37 checks passed
@ayush04 ayush04 deleted the feat/WWP-3314 branch March 1, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This change contains a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants