Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(896): fix package.json test when bump version #897

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

mutebg
Copy link
Contributor

@mutebg mutebg commented Jun 12, 2023

closes #896

What

  1. Background - why this is needed
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@mutebg mutebg marked this pull request as ready for review June 12, 2023 09:05
@github-actions github-actions bot added the fix This change fixes a bug label Jun 12, 2023
@pp-serviceaccount
Copy link
Collaborator

@mutebg mutebg merged commit 1b70066 into main Jun 12, 2023
@mutebg mutebg deleted the fix/896-package-json-test branch June 12, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This change fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test on package.json fails when version bump
4 participants