feat(TMR-1134): refactor form input logic #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When input is optional and also empty don’t show valid styles. Instead leave neutral.
|
You can preview these changes on: |
baburay23
previously approved these changes
Jun 5, 2023
mutebg
previously approved these changes
Jun 6, 2023
baburay23
previously approved these changes
Jun 8, 2023
Xin00163
previously approved these changes
Jun 8, 2023
pdimova
reviewed
Jun 8, 2023
src/form/form-input.tsx
Outdated
| isRequired: boolean | undefined, | ||
| hasContent: boolean, | ||
| ) => { | ||
| if (!isRequired && !hasContent && state === 'valid') return undefined; |
There was a problem hiding this comment.
can we make this line a bit more descriptive? maybe assigning a new variable for the expression ?
pdimova
reviewed
Jun 8, 2023
src/form/__tests__/form.test.tsx
Outdated
| @@ -478,6 +478,75 @@ describe('Form', () => { | |||
| }); | |||
| expect(fragment).toMatchSnapshot(); | |||
| }); | |||
|
|
|||
| test('render optional textfield correctly', async () => { | |||
There was a problem hiding this comment.
can we rename the test to something more descriptive like 'render optional textfield without vlidation icons' or something like this
baburay23
approved these changes
Jun 8, 2023
Xin00163
approved these changes
Jun 8, 2023
pdimova
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty textfields have validation in forms even when they are optional:
This ticket updates the logic so when the text field input is not required and empty no validation visuals are visible.
Before:
After:
What
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: