-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(731) migrate newskit demo to docs site #870
Conversation
You can preview these changes on: |
LGTM, is the dw theme gonna be changed in this ticket? Also in a follow up ticket we could add the font metrics, for proper TextCropping, and I was wondering if we have a video of the DEMO? like someone running over it? Would be nice if we could include it in the home pace |
I am waiting for newscorp-ghfb/newskit-themes-publisher#108 so that I can add the rest of the themes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, Stoyan
closes #731
What
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: