Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(744): remove deprecated aws/eks #869

Merged
merged 2 commits into from
May 4, 2023

Conversation

JohnTParsons
Copy link
Collaborator

@JohnTParsons JohnTParsons commented May 3, 2023

closes #744

What

  1. Background - remove deprecated AWS/EKS steps and MOST OF the legacy AWS env vars (see comments on ticket for details)
  2. What did you do - tidy up
  3. What does the reviewers should expect - pipeline still works

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@pp-serviceaccount
Copy link
Collaborator

@JohnTParsons JohnTParsons marked this pull request as ready for review May 3, 2023 11:52
@JohnTParsons JohnTParsons added the ready for review Please assist in getting this reviewed label May 3, 2023
@JohnTParsons JohnTParsons merged commit 81ae4e7 into main May 4, 2023
@JohnTParsons JohnTParsons deleted the chore/744-remove-deprecated branch May 4, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove AWS/EKS env vars from Circle
4 participants