-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(803): improve contribution guidance for developers #844
Conversation
You can preview these changes on: |
CONTRIBUTING.md
Outdated
If you then still feel the need to ask a question and need clarification, we recommend the following: | ||
|
||
* Open an [Issue](https://github.com/newscorp-ghfb/NewsKit/issues/new/choose) if it is clear what the issue is; otherwise create a new [Discussion](https://github.com/newscorp-ghfb/NewsKit/discussions). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above!
Also I think they can open issues even if is not clear to them what the problem is, as far as is a bug for instance it is fine for them to open an Issue IMO. So Again I would explain the two path Question and Bug/Feature separately. from a question. Feels a bit mixed now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have now combined the information from the original Ask a Question and Suggesting Enhancements sections to reduce the repetition
looking good! 💯 |
closes #803
What
https://github.com/newscorp-ghfb/NewsKit/blob/chore/803-contribution-guidance/CONTRIBUTING.md
and
https://github.com/newscorp-ghfb/NewsKit/tree/chore/803-contribution-guidance#readme (the new link to it in README.md)
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: