Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(730): update video player component scenarios storybook #830

Merged
merged 15 commits into from
Apr 18, 2023

Conversation

JohnTParsons
Copy link
Collaborator

closes #730

What

  1. Background - video player component scenarios out of date
  2. What did you do - updated
  3. What does the reviewers should expect - new (fewer) stories

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the docs Improvements or additions to documentation label Apr 13, 2023
@pp-serviceaccount
Copy link
Collaborator

@JohnTParsons JohnTParsons added ready for review Please assist in getting this reviewed and removed Requires design review labels Apr 17, 2023
@JohnTParsons JohnTParsons marked this pull request as ready for review April 17, 2023 22:05
mutebg
mutebg previously approved these changes Apr 18, 2023
src/video-player/types.ts Show resolved Hide resolved
mutebg
mutebg previously approved these changes Apr 18, 2023
Vanals
Vanals previously approved these changes Apr 18, 2023
@JohnTParsons JohnTParsons dismissed stale reviews from Vanals and mutebg via a3668f9 April 18, 2023 13:37
@JohnTParsons JohnTParsons merged commit 20ece71 into main Apr 18, 2023
@JohnTParsons JohnTParsons deleted the docs/730-video-player-storybook branch April 18, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Video player component interface & Storybook scenarios
4 participants