Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(782): update webpack type definitions #804

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

jps
Copy link
Contributor

@jps jps commented Apr 4, 2023

#782

What

  1. Background - missed type upgrade for webpack
  2. What did you do upgraded web pack type definitions

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@jps jps added the ready for review Please assist in getting this reviewed label Apr 4, 2023
@jps jps added this to the Infrastructure & Release milestone Apr 4, 2023
@jps jps mentioned this pull request Apr 4, 2023
8 tasks
@pp-serviceaccount
Copy link
Collaborator

@jps jps merged commit 405bbb3 into main Apr 6, 2023
@jps jps deleted the build/782-update-webpack-types branch April 6, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants