Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:(726) card composable #802

Merged
merged 73 commits into from
Apr 11, 2023
Merged

feat:(726) card composable #802

merged 73 commits into from
Apr 11, 2023

Conversation

mutebg
Copy link
Contributor

@mutebg mutebg commented Apr 4, 2023

#726

What

  1. Background - implement CardComposable
  2. What did you do - Added a few new components: CardComposable, CardMedia, CardContent, CardLink and CardActions
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

Stoyan Delev and others added 30 commits January 10, 2023 09:56
@mutebg mutebg added the ready for design review Please assist in getting this reviewed label Apr 4, 2023
@mutebg mutebg marked this pull request as ready for review April 4, 2023 12:21
@mutebg mutebg added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Apr 5, 2023
src/card-composable/card-composable.tsx Outdated Show resolved Hide resolved
src/card-composable/card-composable.tsx Show resolved Hide resolved
src/card-composable/styled.tsx Show resolved Hide resolved
src/grid-layout/__tests__/stories/grid-card.tsx Outdated Show resolved Hide resolved
@mstuartf
Copy link
Contributor

mstuartf commented Apr 5, 2023

Looks good!

@mutebg mutebg added breaking change dependencies Pull requests that update a dependency file labels Apr 11, 2023
@mutebg mutebg merged commit 92bf709 into main Apr 11, 2023
@mutebg mutebg deleted the feat/726-card-composable branch April 11, 2023 12:10
@mutebg mutebg removed breaking change ready for review Please assist in getting this reviewed dependencies Pull requests that update a dependency file labels Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This change contains a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Card Composable
5 participants