Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2690): update drawer storybook #716

Merged
merged 10 commits into from
Mar 24, 2023

Conversation

mutebg
Copy link
Contributor

@mutebg mutebg commented Mar 21, 2023

PPDSC-2690

What

  1. Background - why this is needed
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@mutebg mutebg requested a review from a team as a code owner March 21, 2023 12:39
@github-actions github-actions bot added the docs Improvements or additions to documentation label Mar 21, 2023
@mutebg mutebg added the ready for review Please assist in getting this reviewed label Mar 22, 2023
Vanals
Vanals previously approved these changes Mar 23, 2023
Copy link
Collaborator

@JohnTParsons JohnTParsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling of DRAWER_HEADER

src/drawer/__tests__/drawer.stories.tsx Outdated Show resolved Hide resolved
@mutebg mutebg merged commit bcdf108 into main Mar 24, 2023
@mutebg mutebg deleted the docs/PPDSC-2690-update-drawer-stories branch March 24, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants