Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2692): update date-time stories #713

Merged
merged 4 commits into from
Mar 22, 2023

Conversation

mutebg
Copy link
Contributor

@mutebg mutebg commented Mar 17, 2023

PPDSC-2692

What

What did you do - DateTime storybook updates

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@mutebg mutebg requested a review from a team as a code owner March 17, 2023 13:51
@github-actions github-actions bot added the docs Improvements or additions to documentation label Mar 17, 2023
@pp-serviceaccount
Copy link
Collaborator

@mutebg mutebg added ready for design review Please assist in getting this reviewed ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Mar 20, 2023
@mutebg mutebg merged commit a90af6d into main Mar 22, 2023
@mutebg mutebg deleted the docs/PPDSC-2692-date-time-stories branch March 22, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants