Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2803): new menu scenarios #688

Merged
merged 5 commits into from
Mar 14, 2023
Merged

Conversation

mstuartf
Copy link
Contributor

@mstuartf mstuartf commented Mar 6, 2023

PPDSC-2803

What

  1. Background - why this is needed
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@mstuartf mstuartf added the ready for design review Please assist in getting this reviewed label Mar 6, 2023
@mstuartf mstuartf requested a review from a team as a code owner March 6, 2023 16:28
@github-actions github-actions bot added the docs Improvements or additions to documentation label Mar 6, 2023
@pp-serviceaccount
Copy link
Collaborator

@mstuartf mstuartf added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Mar 13, 2023
@mutebg mutebg changed the title docs(PPDSC-2803): new scenarios docs(PPDSC-2803): new menu scenarios Mar 13, 2023
@mstuartf mstuartf merged commit 0fcabc0 into main Mar 14, 2023
@mstuartf mstuartf deleted the docs/PPDSC-2803-menu-stories branch March 14, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants