Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2649): add patterns solutions section #678

Merged
merged 8 commits into from
Mar 9, 2023

Conversation

mstuartf
Copy link
Contributor

@mstuartf mstuartf commented Feb 28, 2023

PPDSC-2649

What

  1. Background - why this is needed
  • New solutions section on patterns page
  1. What did you do
  • Added section
  1. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@mstuartf mstuartf added the ready for design review Please assist in getting this reviewed label Feb 28, 2023
@mstuartf mstuartf requested a review from a team as a code owner February 28, 2023 15:22
@github-actions github-actions bot added the docs Improvements or additions to documentation label Feb 28, 2023
@pp-serviceaccount
Copy link
Collaborator

@mstuartf mstuartf added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Mar 7, 2023
Vanals
Vanals previously approved these changes Mar 7, 2023
@mstuartf mstuartf merged commit dd7086b into main Mar 9, 2023
@mstuartf mstuartf deleted the docs/PPDSC-2649-solutions branch March 9, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants