Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(PPDSC-2819): update StructuredList component storybook scenarios #673

Merged
merged 5 commits into from
Mar 1, 2023
Merged

docs(PPDSC-2819): update StructuredList component storybook scenarios #673

merged 5 commits into from
Mar 1, 2023

Conversation

evgenitsn
Copy link
Contributor

@evgenitsn evgenitsn commented Feb 27, 2023 •
edited
Loading

PPDSC-2819

What

  1. Background - update Storybook scenarios
  2. What did you do - update StructuredList storybook scenarios

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:
image
After:
image
Who should review this PR:

How to test:

@evgenitsn evgenitsn added docs Improvements or additions to documentation Requires design review labels Feb 27, 2023
@evgenitsn evgenitsn requested a review from a team as a code owner February 27, 2023 12:07
@pp-serviceaccount
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/ppdsc-2819-update-structured-list-component-storybook-scenarios
Storybook: http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/ppdsc-2819-update-structured-list-component-storybook-scenarios/storybook

LukeFinch
LukeFinch previously approved these changes Feb 27, 2023
View reviewed changes
@evgenitsn evgenitsn added ready for review Please assist in getting this reviewed and removed Requires design review labels Feb 28, 2023
@evgenitsn evgenitsn merged commit 666b8b0 into main Mar 1, 2023
@evgenitsn evgenitsn deleted the docs/PPDSC-2819-update-structured-list-component-storybook-scenarios branch March 1, 2023 08:41
JohnTParsons pushed a commit that referenced this pull request Mar 7, 2023
@evgenitsn
docs(PPDSC-2819): update StructuredList component storybook scenarios (…
a039c30 
…#673)

* docs(PPDSC-2819): update StructuredList component storybook scenarios

* docs(PPDSC-2819): update aria labels

* docs(PPDSC-2819): fix e2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutebg mutebg mutebg approved these changes

@Xin00163 Xin00163 Xin00163 approved these changes

@LukeFinch LukeFinch LukeFinch left review comments

Assignees
No one assigned
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@evgenitsn @pp-serviceaccount @mutebg @Xin00163 @LukeFinch