chore(PPDSC-2611): fewer tests for baseline updates #588
Conversation
mstuartf
added
the
draft
mstuartf
changed the title
mstuartf
added
ready for review
|
You can preview these changes on: |
| const data = url.includes('/api/v1/builds') ? BUILDS : SNAPSHOTS; | ||
| streamStream.emit('data', JSON.stringify(data)); | ||
| streamStream.emit('end'); | ||
| }; |
There was a problem hiding this comment.
This is nice. I've only seen people using a npm packages. Didn't know this simple but effective solution
| echo "Baseline updates required; continuing job." | ||
| } | ||
| export PR_BRANCH_NAME=$(gh pr list --search $CIRCLE_SHA1 --state merged --json headRefName --jq '.[].headRefName') | ||
| echo "Found branch name: ${PR_BRANCH_NAME}" |
There was a problem hiding this comment.
Is is worth adding a comment so that people know this env variable name
PERCY_${project.toUpperCase()}_TOKEN is linked to the comps passed here?
There was a problem hiding this comment.
Good point, perhaps it's not that clear. Looking at it, I think we should just set the PERCY_TOKEN value here and the script should assume that this is already set (I can comment that this is the case). The only reason the comps arg is passed is for setting the token.
What do you think?
* fix(PPDSC-2611): Revert "Fix/ppdsc 2611 fix 1 (#629)" This reverts commit 7ee4a68. * fix(PPDSC-2611): Revert "fix(PPDSC-2611): fix pipeline (#596)" This reverts commit 1c001a9. * fix(PPDSC-2611): Revert "chore(PPDSC-2611): fewer tests for baseline updates (#588)" This reverts commit fd4d458.
PPDSC-2611
What
includesettingI have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: