chore(PPDSC-1580): upgrade to jest 29

[JohnTParsons]

PPDSC-1580

What

1. Background - Jest 29 seems to be 20-30% quicker than Jest 28. Please read https://nidigitalsolutions.jira.com/browse/PPDSC-1580?focusedCommentId=539031 for full background
2. What did you do. Upgrade Jest
3. What does the reviewers should expect. All tests still passing

I have done:

• Written unit tests against changes
• Written functional tests against the component and/or NewsKit site
• Updated relevant documentation

I have tested manually:

• The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
• The screen reader reads and flows through the elements as expected.
• There are no new errors in the browser console coming from this PR.
• When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
• The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

[pp-serviceaccount]

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-1580-upgrade-jest-29
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-1580-upgrade-jest-29/storybook

[Xin00163]

I am not sure if it's my local machine, the tests run is still very slow for me

svg-previewer test is failing for me as well:

I am getting some validation warnings. See below:

[JohnTParsons]

The validation warnings are a known bug in Jest 29 @Xin Wang ***@***.***> Which Node version are you using? That svg-previewer test seems flaky. Passes 99% of the time when I run it. Stoyan says, "On my laptop unit tests run slower than version 27 ( using Node 16.13 ). I switched to node 16.10 and seems 20% faster as you mentioned." I told him, "I was mainly doing speed testing on Node 16.10 and did one final check on Node 16.13 just to confirm it didn't run out of memory. There is a separate ticket to focus on speed improvements after doing this upgrade. 09:17 <https://newsuktechnology.slack.com/archives/D04EZ9TMYR1/p1674465435867889> If you change the 2 instances of workerIdleMemoryLimit: 0.4 to workerIdleMemoryLimit: 1.0 (or remove that new Jest 29 prop), you might see the same speed as before under Node 16.13?That setting was to address out of memory issues reported with Node 16.13+. Mike Flood advised all devs last week to use Node 16.10 (eg using nvm use 16.10.0). Sadly, the pipeline's Docker images are 16.13 ones."

…

On Mon, 23 Jan 2023 at 10:20, Xin Wang ***@***.***> wrote: ***@***.**** commented on this pull request. I am not sure if it's my local machine, the tests run is still very slow for me [image: Screenshot 2023-01-23 at 10 17 59] <https://user-images.githubusercontent.com/12214841/214015540-038e3c44-a4f8-4437-b453-8d3449747061.png> svg-previewer test is failing for me as well: [image: Screenshot 2023-01-23 at 09 34 31] <https://user-images.githubusercontent.com/12214841/214015137-68673958-6e03-41f8-9413-7f84984ccde7.png> I am getting some validation warnings. See below: [image: Screenshot 2023-01-23 at 09 19 17] <https://user-images.githubusercontent.com/12214841/214015701-532103d8-9d70-44fe-8b58-300ae83d186c.png> — Reply to this email directly, view it on GitHub <#576 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD7ERLNDC2SRPCHVOSAU5JLWTZLNTANCNFSM6AAAAAAUBIXF3I> . You are receiving this because you authored the thread.Message ID: ***@***.***>

--

-- "Please consider the environment before printing this e-mail" This e-mail and any attachments are confidential, may be legally privileged and are the property of News Corp UK & Ireland Limited on whose systems they were generated. News Corp UK & Ireland Limited is the holding company for the News UK group, is registered in England & Wales under number 81701, has its registered office at 1 London Bridge Street, London, SE1 9GF and is registered with VAT number GB 243 8054 69. If you have received this e-mail in error, please notify the sender immediately and do not use, distribute, store or copy it in any way. Statements or opinions in this e-mail or any attachment are those of the author and are not necessarily agreed or authorised by News Corp UK & Ireland Limited or any member of its group. News Corp UK & Ireland Limited may monitor outgoing or incoming emails as permitted by law.  It acceptsno liability for viruses introduced by this e-mail or attachments.  News Corp UK & Ireland Limited and its titles are committed to abiding by IPSO's regulations and the Editors' Code of Practice that IPSO enforces.

[Xin00163]

Thanks @JohnTParsons. Will give v16.10 a try

What a difference. Shocking 😱