Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2571): refactor Meta component #572

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

evgenitsn
Copy link
Contributor

PPDSC-2571

What

  1. Background - Meta component was built using old components and techniques
  2. What did you do - Refactor Meta component to use GridLayout
  3. What does the reviewers should expect - no visual changes, just code simplification

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@evgenitsn evgenitsn added docs Improvements or additions to documentation ready for review Please assist in getting this reviewed labels Jan 19, 2023
@evgenitsn evgenitsn requested a review from a team as a code owner January 19, 2023 08:32
@evgenitsn evgenitsn merged commit 678b0fe into main Jan 20, 2023
@evgenitsn evgenitsn deleted the docs/PPDSC-2571-refactor-meta-component branch January 20, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants