-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(PPDSC-1581): upgrade to cypress 12 #549
Conversation
You can preview these changes on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In search.cy.js, please remove "cy.contains('Search').click({force: true});" and bring back "cy.get(${DESKTOP_NAV} ${SEARCH_BTN}
).click();"
This was just a temporary hack I needed to do to keep the tests running after the recent upgrade of next.js to v.13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! Do you think it's worth using the component testing feature or it's not needed for now?
cypress.docs.config.ts
Outdated
|
||
export default defineConfig({ | ||
e2e: { | ||
setupNodeEvents(on, config) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this plugin for docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do but you make a good point as we don't need it for any of the others. Will remove!
cypress.components.config.ts
Outdated
|
||
export default defineConfig({ | ||
e2e: { | ||
setupNodeEvents(on, config) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be OK just to import the file const setupNodeEvents = require('./cypress/plugins/index.js')
? https://docs.cypress.io/guides/references/migration-guide#Config-Option-Changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to match the intended new structure. Will just check the pipeline is ok then ready for another look. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another great one 👏
PPDSC-1581
What
test_newskit_in_nextjs_app
jobI have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: