Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2601): update Accordion component storybook scenarios #519

Merged

Conversation

evgenitsn
Copy link
Contributor

PPDSC-2601

What

  1. Background - updating the Storybook scenarios
  2. What did you do - updated Accordion component scenarios
  3. What does the reviewers should expect - new stories for Accordion

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:
image

After:
image

Who should review this PR:

How to test:

@evgenitsn evgenitsn requested a review from a team as a code owner December 13, 2022 07:32
@github-actions github-actions bot added the docs Improvements or additions to documentation label Dec 13, 2022
@evgenitsn evgenitsn added the ready for design review Please assist in getting this reviewed label Dec 13, 2022
JohnTParsons
JohnTParsons previously approved these changes Dec 13, 2022
@evgenitsn evgenitsn added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Dec 13, 2022
@@ -17,6 +17,7 @@ import {
} from '../src/instrumentation';

const unlimitedScenarios = [
'Accordion',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is still needed, but is something we can discuss with Mike when is back.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added it because one of the story pages was with too long height and it was getting cut off because of the overflow: hidden. This way by adding it here this is fixed. If we are not constrained by page height for Percy I think we can just remove the logic for fixed height and overflow hidden so that every scenario is a "unlimited" scenario. But yeah, worth discussing with Mike.

@evgenitsn evgenitsn merged commit 02740f5 into main Dec 19, 2022
@evgenitsn evgenitsn deleted the docs/PPDSC-2601-update-accordion-component-storybook-scenarios branch December 19, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants