Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2627) updated overrides in doc sites #516

Merged

Conversation

RashikaNewsUK
Copy link
Contributor

PPDSC-2627

What

  1. Background - why this is needed
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@RashikaNewsUK RashikaNewsUK added the bug Something isn't working label Dec 9, 2022
@RashikaNewsUK RashikaNewsUK requested a review from a team as a code owner December 9, 2022 05:27
@github-actions github-actions bot added the docs Improvements or additions to documentation label Dec 9, 2022
@RashikaNewsUK RashikaNewsUK added Requires design review ready for review Please assist in getting this reviewed and removed Requires design review labels Dec 9, 2022
@baburay23 baburay23 self-requested a review December 13, 2022 10:29
@RashikaNewsUK RashikaNewsUK merged commit 38a6988 into main Dec 13, 2022
@RashikaNewsUK RashikaNewsUK deleted the docs/PPDSC-2627-update-overrides-in-documentations branch December 13, 2022 12:02
@RashikaNewsUK RashikaNewsUK removed the ready for review Please assist in getting this reviewed label Dec 13, 2022
JohnTParsons pushed a commit that referenced this pull request Dec 14, 2022
JohnTParsons added a commit that referenced this pull request Dec 20, 2022
* refactor(PPDSC-2606): update feature card component & copy

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.2.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md)
- [Commits](webpack/loader-utils@v1.4.0...v1.4.2)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: baburay23 <54642337+baburay23@users.noreply.github.com>

* chore(DEPS): bump qs from 6.5.2 to 6.5.3 (#508)

Bumps [qs](https://github.com/ljharb/qs) from 6.5.2 to 6.5.3.
- [Release notes](https://github.com/ljharb/qs/releases)
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
- [Commits](ljharb/qs@v6.5.2...v6.5.3)

---
updated-dependencies:
- dependency-name: qs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: baburay23 <54642337+baburay23@users.noreply.github.com>

* docs(PPDSC-2627): docs(PPDSC-2627) updated overrides in doc sites (#516)

updated overrides in doc site

* chore(DEPS): bump express from 4.17.1 to 4.18.2 (#513)

Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.18.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.17.1...4.18.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: baburay23 <54642337+baburay23@users.noreply.github.com>

* docs(PPDSC-2557): update Byline component storybook scenarios (#511)

* refactor(PPDSC-2606): new release feature card

* refactor(PPDSC-2606): fix styling issues from design review

* refactor(PPDSC-2606): refactor featurecard props

* refactor(PPDSC-2606): remove interactivity; standardise border radius

* refactor(PPDSC-2606): fix merge conflict

* refactor(PPDSC-2606): remove leftovers

* refactor(PPDSC-2606): link*Persistent to site/theme/style-presets.ts

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: John Parsons <john.parsons@f2cxgrkwp0.home>
Co-authored-by: Evgeni Nikolov <evgeni.nikolov@news.co.uk>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: baburay23 <54642337+baburay23@users.noreply.github.com>
Co-authored-by: Rashika <113605781+RashikaNewsUK@users.noreply.github.com>
Co-authored-by: JohnTParsons <JohnTParsons>
Co-authored-by: Marco Vanali <Marco91Vanali@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants