Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PPDSC-2555): SVG Exporter - Export with CSS vars #493

Merged
merged 17 commits into from
Dec 2, 2022

Conversation

LukeFinch
Copy link
Contributor

PPDSC-2555

What

  • Removed the tsx export from svg previewer
  • Replaced embedded NewsKit token names with css-variables

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the feature This change contains a new feature label Nov 28, 2022
@LukeFinch LukeFinch added the ready for review Please assist in getting this reviewed label Nov 28, 2022
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`SvgPreviewer should change theme colors correctly when selecting a different theme from select element 1`] = `
<DocumentFragment>
Copy link
Contributor

@Vanals Vanals Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are the svg-previewer tests gone? 🤔 Could you add them back? I cannot even see them from the list of files deleted. I wonder if is part of the "mess up" when it was being moved to '/tool'. We should have tests in place!. Also we have colors-theme-list.tsx within tests now. I think is shouldn't be there.

IF the tests are disappeared completely you might want to look back in the git hystory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm weird. I'll look into it 👍

@LukeFinch LukeFinch removed the ready for review Please assist in getting this reviewed label Nov 28, 2022
site/components/svg-previewer/svg-previewer.tsx Outdated Show resolved Hide resolved
site/components/svg-previewer/svg-previewer.tsx Outdated Show resolved Hide resolved
site/components/svg-previewer/styled.tsx Outdated Show resolved Hide resolved
src/popover/__tests__/__snapshots__/popover.test.tsx.snap Outdated Show resolved Hide resolved
@LukeFinch LukeFinch added the ready for review Please assist in getting this reviewed label Nov 30, 2022
@LukeFinch LukeFinch requested a review from a team as a code owner December 1, 2022 12:52
Copy link
Contributor

@mutebg mutebg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @LukeFinch 👏

@LukeFinch LukeFinch merged commit cdc2dd7 into main Dec 2, 2022
@LukeFinch LukeFinch deleted the feat/PPDSC-2555-svg-exporter-css-vars branch December 2, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This change contains a new feature ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants