-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(PPDSC-2555): SVG Exporter - Export with CSS vars #493
Conversation
You can preview these changes on: |
// Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
||
exports[`SvgPreviewer should change theme colors correctly when selecting a different theme from select element 1`] = ` | ||
<DocumentFragment> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are the svg-previewer tests gone? 🤔 Could you add them back? I cannot even see them from the list of files deleted. I wonder if is part of the "mess up" when it was being moved to '/tool'. We should have tests in place!. Also we have colors-theme-list.tsx within tests now. I think is shouldn't be there.
IF the tests are disappeared completely you might want to look back in the git hystory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm weird. I'll look into it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @LukeFinch 👏
PPDSC-2555
What
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: