Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(PPDSC-2481): add marketwatch and wsj themes #492

Merged
merged 10 commits into from
Dec 8, 2022

Conversation

mstuartf
Copy link
Contributor

PPDSC-2481

What

  1. Background - why this is needed
  • Users want to see Storybook components in their own themes
  1. What did you do
  • Added MArketwatch at WSJ themes to Storybook
  1. What does the reviewers should expect
  • Able to select MW and WSJ themes in toolbar dropdown

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@newskit-engineering
Copy link
Collaborator

@mstuartf mstuartf added docs Improvements or additions to documentation ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Nov 28, 2022
mutebg
mutebg previously approved these changes Nov 28, 2022
mutebg
mutebg previously approved these changes Dec 6, 2022
fontFamily: "Retina",
sources: [
`${fontCdnWSJ}/woffs/retina/Retina-BookItalic.woff2`,
`${fontCdnWSJ}/woffs/retina/Retina-BookItalic.woff`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should get rid of woff files, they just make noise, all modern browsers support woff2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the one you just removed, do you need to also update the @font-face? I think some are still looking for woff file even now we are not downloading it anymore!

I would maybe then just double check everything still looks good, but should be ok

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

mutebg
mutebg previously approved these changes Dec 6, 2022
mutebg
mutebg previously approved these changes Dec 6, 2022
@mstuartf mstuartf merged commit ccb1e1e into main Dec 8, 2022
@mstuartf mstuartf deleted the chore/PPDSC-2481-themes branch December 8, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants