Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(PPDSC-2607): checkout workspace before check #489

Merged
merged 3 commits into from
Nov 24, 2022

Conversation

mstuartf
Copy link
Contributor

PPDSC-2607

What

  1. Background - why this is needed
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@mstuartf mstuartf added the ready for review Please assist in getting this reviewed label Nov 23, 2022
@newskit-engineering
Copy link
Collaborator

Copy link
Contributor

@Vanals Vanals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, had a quick look, I think there are a few things definitely wrong, and some I am now sure about, I think might be getting a bit messy. We can have a look tmr 👍

If you can add some description, and links to useful related pipelines to have a look at would help me tmr 🙏

@mstuartf mstuartf added the fix This change fixes a bug label Nov 24, 2022
@mstuartf mstuartf merged commit ce75310 into main Nov 24, 2022
@mstuartf mstuartf deleted the chore/PPDSC-2607-checkout-fix branch November 24, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This change fixes a bug ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants