Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2525): sub menu added in menu documentaion #484

Merged
merged 6 commits into from
Nov 23, 2022

Conversation

RashikaNewsUK
Copy link
Contributor

PPDSC-2525

What

  1. Background - why this is needed
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@RashikaNewsUK RashikaNewsUK added the docs Improvements or additions to documentation label Nov 22, 2022
@RashikaNewsUK RashikaNewsUK added the ready for design review Please assist in getting this reviewed label Nov 22, 2022
@RashikaNewsUK RashikaNewsUK added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Nov 23, 2022
@RashikaNewsUK RashikaNewsUK merged commit 60f2e14 into main Nov 23, 2022
@RashikaNewsUK RashikaNewsUK deleted the docs/PPDSC-2525-sub-menu-documentaion branch November 23, 2022 11:09
@RashikaNewsUK RashikaNewsUK removed the ready for review Please assist in getting this reviewed label Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants