Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs:(PPDSC-2549) components content updates #456

Merged
merged 6 commits into from
Nov 9, 2022

Conversation

jamestnew
Copy link
Contributor

PPDSC-XXXX

What

  1. Background - why this is needed
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the docs Improvements or additions to documentation label Nov 3, 2022
Copy link
Contributor

@mutebg mutebg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your unit tests are failing, you need to run yarn test:unit:site -u in order to update snapshots and make another commit & push.
Let me know if you need assistance with that.

site/pages/components/button.tsx Outdated Show resolved Hide resolved
site/pages/components/button.tsx Outdated Show resolved Hide resolved
@mutebg mutebg changed the title Docs/ppdsc 2549 components content updates docs:(PPDSC-2549) components content updates Nov 7, 2022
@mutebg mutebg added the ready for review Please assist in getting this reviewed label Nov 7, 2022
@jamestnew jamestnew requested a review from mutebg November 7, 2022 10:53
package.json Outdated
@@ -219,6 +219,7 @@
"@seznam/compose-react-refs": "^1.0.5",
"@storybook/react": "^6.5.9",
"aria-hidden": "^1.1.3",
"caniuse-lite": "^1.0.30001431",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this library, I can't see we use it anywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. I just ran the yarn test:unit:site -u then committed the branch and pushed it once all the tests passed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this should not be here, I can remove it for you and merge the PR if you want

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be great, thanks Stoyan.

@mutebg mutebg merged commit da22fc5 into main Nov 9, 2022
@mutebg mutebg deleted the docs/PPDSC-2549-components-content-updates branch November 9, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants