-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs:(PPDSC-2549) components content updates #456
Conversation
update content
checkbox updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your unit tests are failing, you need to run yarn test:unit:site -u
in order to update snapshots and make another commit & push.
Let me know if you need assistance with that.
package.json
Outdated
@@ -219,6 +219,7 @@ | |||
"@seznam/compose-react-refs": "^1.0.5", | |||
"@storybook/react": "^6.5.9", | |||
"aria-hidden": "^1.1.3", | |||
"caniuse-lite": "^1.0.30001431", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of this library, I can't see we use it anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure. I just ran the yarn test:unit:site -u
then committed the branch and pushed it once all the tests passed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this should not be here, I can remove it for you and merge the PR if you want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be great, thanks Stoyan.
You can preview these changes on: |
PPDSC-XXXX
What
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: