Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2548): update content #453

Merged
merged 5 commits into from
Nov 7, 2022

Conversation

GeriReid
Copy link
Contributor

@GeriReid GeriReid commented Nov 3, 2022

PPDSC-2548

What

  1. Background - why this is needed
    Content update from Tom's edits
  2. What did you do
    Updated text from: https://docs.google.com/document/d/1ygayWr9V7txO66NDLtRWI7a6qYlENV8isTp2h8ZMHMw/edit?usp=sharing
  3. What does the reviewers should expect
    Text to match doc

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the docs Improvements or additions to documentation label Nov 3, 2022
@GeriReid GeriReid force-pushed the docs/PPDSC-2548-presets-content-updates branch from 2265ab8 to e5b96be Compare November 3, 2022 16:53
@mutebg mutebg added the ready for review Please assist in getting this reviewed label Nov 7, 2022
@LukeFinch LukeFinch merged commit eec6298 into main Nov 7, 2022
@LukeFinch LukeFinch deleted the docs/PPDSC-2548-presets-content-updates branch November 7, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants